Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure fetching column from transient row persists changes where needed #188

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

camsaul
Copy link
Owner

@camsaul camsaul commented Oct 7, 2024

Fixes #187

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 85.41667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.58%. Comparing base (8ad9279) to head (e260a65).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/toucan2/jdbc/row.clj 85.41% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   83.18%   83.58%   +0.40%     
==========================================
  Files          37       37              
  Lines        2503     2497       -6     
  Branches      213      212       -1     
==========================================
+ Hits         2082     2087       +5     
+ Misses        208      198      -10     
+ Partials      213      212       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camsaul camsaul merged commit 352d181 into master Oct 7, 2024
10 checks passed
@camsaul camsaul deleted the fix-187 branch October 7, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

valAt implementation for TransientRow not persisting changes to the underlying transient map
1 participant